Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update package.json #130

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: update package.json #130

wants to merge 1 commit into from

Conversation

subhamg
Copy link

@subhamg subhamg commented Oct 29, 2024

No description provided.

@subhamg subhamg changed the title Update package.json chore: update package.json Oct 29, 2024
@coolsoftwaretyler
Copy link
Collaborator

Hey @subhamg - thanks for your PR!

We are working on a milestone for getting the repository ready for more contribution so we'll probably hold off on this until we finish up #129. If you want to help out, there are some details in that PR about the status of the change.

@@ -23,7 +23,7 @@
"build": "cross-env NODE_ENV=production webpack"
},
"peerDependencies": {
"mobx": "^2.2.0 || ^3.0.0 || ^4.0.0 || ^5.0.0",
"mobx": "^2.2.0 || ^3.0.0 || ^4.0.0 || ^5.0.0 || ^6.0.0 || ^6.13.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"mobx": "^2.2.0 || ^3.0.0 || ^4.0.0 || ^5.0.0 || ^6.0.0 || ^6.13.0",
"mobx": "^2.2.0 || ^3.0.0 || ^4.0.0 || ^5.0.0 || ^6.0.0",

I think ^6.0.0 should work to do what ^6.13.0 is doing here. Was there a specific reason you had wanted to include that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants